Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deeply read right ab test #1365

Merged
merged 6 commits into from
May 16, 2024
Merged

Deeply read right ab test #1365

merged 6 commits into from
May 16, 2024

Conversation

DanielCliftonGuardian
Copy link
Contributor

@DanielCliftonGuardian DanielCliftonGuardian commented May 7, 2024

What does this change?

Adds 650px to top of desktopRightRailAds when in deeplyReadMostViewed test variant

Why?

Corresponding change to DCR (pr guardian/dotcom-rendering#11299)
Frontend (pr guardian/frontend#27084)

Copy link

changeset-bot bot commented May 7, 2024

🦋 Changeset detected

Latest commit: daf600c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/commercial Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DanielCliftonGuardian DanielCliftonGuardian changed the title Add 650px to top of desktopRightRailAds when in deeplyReadMostViewed … Deeply read right ab test May 7, 2024
@DanielCliftonGuardian DanielCliftonGuardian marked this pull request as ready for review May 7, 2024 16:06
@DanielCliftonGuardian DanielCliftonGuardian requested a review from a team as a code owner May 7, 2024 16:06
Copy link
Member

@Jakeii Jakeii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just need to add a changeset

@domlander domlander merged commit 060642b into main May 16, 2024
10 checks passed
@domlander domlander deleted the deeply-read-right-test branch May 16, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants