chore: Fix beta release versioning #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emma-imber
changed the title
emma-imber
force-pushed
the
ei/fix-beta-versioning
branch
from
0503e11
to
7eda2fd
Compare
emma-imber
added
the
[beta] @guardian/commercial
|
🚀 @guardian/commercial-v8.0.2-beta.0 published to npm as a beta release |
emma-imber
removed
the
[beta] @guardian/commercial
|
🎉 This PR is included in version 8.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Amends the grep command in the beta release script to return the latest release version tags.
Why?
The beta release versioning was using out of date versions because it was searching the git tag entries to find the latest versions. Now that bundle and core are merged, the release version tags are no longer prefixed with commerical-bundle or commercial-core in the tags, and are now just v8.0.0, for example. By removing the @guardian/commercial prefix from the grep command, we will find the latest tag version and assign the correct version number to the beta release.
Basically, tags used to look like this:
And they now look like this:
So we need to update the grep code accordingly.