Re-implement AMP page checks. #1033
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
akinsola-guardian
changed the title
AshCorr
reviewed
Aug 2, 2024
| const cookies = await page.context().cookies(); | ||
|
|
||
| for(const cookie of cookies) { | ||
| await page.context().clearCookies(cookie); |
There was a problem hiding this comment.
How is this better than clearCookies()? Could maybe do with a comment for future travellers so nobody ends up "optimizing" this and reverting your change!
AshCorr
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
page.context().clearCookies()to iteratively clear the list of cookies.run.shto callyarn startrepeatedly.CheckPagesPropstype to tcfv2 function.Why?
AMP pages were not clearing cookies effectively.
This has been tested locally and in CODE.
Link to Trello