Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Nx configs from project.json to package.json #1334

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Move Nx configs from project.json to package.json #1334

merged 1 commit into from
Apr 8, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Apr 4, 2024

What are you changing?

Moving all project-level Nx config from project.json files to the project's package.json.

Why?

project.json is too Nx-specific for the unfamiliar, and doesn’t offer us anything, since we’re very much in a Node world.

It also sets up an easier transition to wireit (wireit also puts its config in package.json.

@sndrs sndrs requested review from a team as code owners April 4, 2024 14:16
@sndrs sndrs requested a review from a team April 4, 2024 14:16
@sndrs sndrs requested a review from a team as a code owner April 4, 2024 14:16
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8860bc1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@sndrs sndrs mentioned this pull request Apr 4, 2024
Closed
@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Apr 4, 2024
oliverabrahams
oliverabrahams approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@oliverabrahams oliverabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sndrs
move all Nx config to package.jsons
8860bc1 
`project.json` is too Nx-specific for the unfamiliar, and doesn’t offer us anything, since we’re very much in a Node world.

It also sets up an easier transition to `wireit`.
@sndrs sndrs enabled auto-merge (squash) April 8, 2024 09:33
@sndrs sndrs merged commit a2c0777 into main Apr 8, 2024
20 checks passed
@sndrs sndrs deleted the wireit/project-json-pkg branch April 8, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverabrahams oliverabrahams oliverabrahams approved these changes

Assignees
No one assigned
Labels
@guardian/ab-core @guardian/ab-react @guardian/browserslist-config @guardian/eslint-config @guardian/eslint-config-typescript @guardian/libs @guardian/prettier @guardian/tsconfig 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied 🛠 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sndrs @oliverabrahams