Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore build-process files in tsconfigs #1467

Merged
merged 1 commit into from
May 21, 2024
Merged

Ignore build-process files in tsconfigs #1467

merged 1 commit into from
May 21, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented May 20, 2024 •
edited
Loading

What are you changing?

adding pipeline dirs to tsconfig#exclude settings

Why?

make sure ts is not looking at things it should ignore

@sndrs sndrs requested review from a team as code owners May 20, 2024 16:20
@sndrs sndrs requested a review from a team May 20, 2024 16:20
@sndrs sndrs requested a review from a team as a code owner May 20, 2024 16:20
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 20, 2024

⚠️ No Changeset found

Latest commit: b2295dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label May 20, 2024
@sndrs sndrs enabled auto-merge (squash) May 20, 2024 17:18
@sndrs sndrs merged commit ecd3d3a into main May 21, 2024
22 checks passed
@sndrs sndrs deleted the sndrs/tsconfig-ignore branch May 21, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmockett jamesmockett jamesmockett approved these changes

Assignees
No one assigned
Labels
@guardian/ab-core @guardian/ab-react @guardian/browserslist-config @guardian/libs 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sndrs @jamesmockett