Add AB test to use propertyId in CMP sourcepoint config
#1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d422d4f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
Jakeii
force-pushed
the
jlk/sourcepoint-propertyid
branch
from
db97eae
to
59437be
Compare
emma-imber
approved these changes
Jun 18, 2024
sndrs
reviewed
Jun 18, 2024
Jakeii
added
the
🐥 Canaries
Jakeii
changed the title
propertyId instead of propertyHref in CMP sourcepoint configpropertyId in CMP sourcepoint config
akinsola-guardian
approved these changes
Jun 20, 2024
mxdvl
approved these changes
Jun 20, 2024
sndrs
approved these changes
Jun 20, 2024
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing?
Testing the suggested change from sourcepoint documentation, to use
propertyIdrather thanpropertyHrefMost of the world uses a single id, but Australia has their own for some reason.
Why?
When using
propertyHrefsourcepoint uses an extra network request to determine consent, currently there's 2-3 requests depending on if there are any changes on sourcepoint's side i.e. to the vendorlist. After this change it will be reduced to 1-2.This should speed up getting consent by 50-33% as it appears to be mostly network bound, and therefore anything else that waits for consent, e.g. advertising.
Before:
After: