Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify removeData #1569

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Simplify removeData #1569

merged 4 commits into from
Jul 1, 2024

Conversation

mxdvl
Copy link
Contributor

@mxdvl mxdvl commented Jun 20, 2024

What are you changing?

  • ensure that undefined values default to an empty array so we do not need to check if they are defined.

Why?

  • simpler code, less variations to handle
  • less code sent over the wire

ensure that undefined values default
to an empty array so we do not need
to check if they are defined
Copy link

changeset-bot bot commented Jun 20, 2024

🦋 Changeset detected

Latest commit: 8418fc6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 📦 npm Affects a @guardian package on NPM @guardian/libs labels Jun 20, 2024
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@mxdvl mxdvl marked this pull request as ready for review June 20, 2024 10:26
@mxdvl mxdvl requested review from a team as code owners June 20, 2024 10:26
@mxdvl mxdvl requested a review from Jakeii June 20, 2024 10:27
@mxdvl mxdvl added the run_chromatic Runs chromatic when label is applied label Jun 24, 2024
@mxdvl mxdvl enabled auto-merge (squash) June 24, 2024 18:41
Copy link
Contributor

@jamesgorrie jamesgorrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unfamiliar with this code, and it is now easier to read!

@mxdvl mxdvl merged commit a5498b8 into main Jul 1, 2024
19 checks passed
@mxdvl mxdvl deleted the mxdvl/refactor-remove-data branch July 1, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@guardian/libs 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants