Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump types packages across all projects to latest minor version #503

Closed
wants to merge 0 commits into from
Closed

Bump types packages across all projects to latest minor version #503

wants to merge 0 commits into from

Conversation

jamesmockett
Copy link
Contributor

What are you changing?

  • Bump types packages across all projects to latest minor version

@jamesmockett jamesmockett requested review from a team as code owners April 12, 2023 14:32
@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2ad4c92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 📦 lib Affect a @csnx lib 📦 npm Affects a @guardian package on NPM labels Apr 12, 2023
@ob6160 ob6160 added the run_chromatic Runs chromatic when label is applied label Apr 12, 2023
mxdvl
mxdvl reviewed Apr 12, 2023
View reviewed changes
libs/@csnx/hello-world/package.json Outdated
Comment on lines 5 to 6
"@types/jest": "29.5.0",
"jest": "29.3.1",
Copy link
Contributor

@mxdvl mxdvl Apr 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect as per the DefinitelyTyped contract: major and minor must match the local dependency.

The draft package linter tool may eventually catches these kinds of problems.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's a good point 🤦 We were trying to break down the dependency updates into smaller chunks, but this is probably a little too granular. I'll update…

@joecowton1 joecowton1 self-requested a review April 12, 2023 15:29
@github-actions github-actions bot removed 📦 npm Affects a @guardian package on NPM 📦 lib Affect a @csnx lib labels Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxdvl mxdvl mxdvl left review comments

@joecowton1 joecowton1 Awaiting requested review from joecowton1

Assignees
No one assigned
Labels
run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesmockett @mxdvl @joecowton1 @ob6160