-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce CLS for inline1 when Teads passback - step 2 #11698
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +86 B (+0.01%) Total Size: 842 kB
ℹ️ View Unchanged
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
deedeeh
changed the title
Reduce CLS (layout shift) for inline1 when Teads passback
Reduce CLS for inline1 when Teads passback - step 2
Jun 20, 2024
domlander
approved these changes
Jun 21, 2024
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR reserves 350px instead of 250px for
inline1
slot in articles. This is the stage 2 in two steps work. Please check stage 1 for more info guardian/commercial#1417This PR should be merged after the stage 1 PR is merged.
The change is tested locally and in CODE.
The before recording is taken after we merge step 1.
Why?
Reduce CLS for better user experience.
Recordings
Before
Screen.Recording.2024-06-20.at.11.43.16.mov
After
Screen.Recording.2024-06-20.at.11.47.04.mov