-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fairground 🎡] Remove opinion/comment style footer #11699
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Jun 20, 2024
Size Change: -856 B (-0.1%) Total Size: 843 kB
ℹ️ View Unchanged
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
cemms1
force-pushed
the
fairground/remove-comment-footer
branch
from
June 20, 2024 16:08
6c7620e
to
5ccd542
Compare
cemms1
added
run_chromatic
Runs chromatic when label is applied
and removed
run_chromatic
Runs chromatic when label is applied
labels
Jun 20, 2024
cemms1
force-pushed
the
fairground/remove-comment-footer
branch
from
June 20, 2024 16:14
5ccd542
to
c076268
Compare
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Jun 20, 2024
cemms1
force-pushed
the
fairground/remove-comment-footer
branch
from
June 21, 2024 11:07
c076268
to
cee4fef
Compare
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Jun 21, 2024
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Jun 21, 2024
cemms1
force-pushed
the
fairground/remove-comment-footer
branch
from
June 24, 2024 10:44
00a5811
to
4604bcd
Compare
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Jun 24, 2024
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Jun 24, 2024
cemms1
force-pushed
the
fairground/remove-comment-footer
branch
from
June 24, 2024 16:24
8a4362a
to
da8dd60
Compare
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Jun 24, 2024
…ing decisions for content
cemms1
force-pushed
the
fairground/remove-comment-footer
branch
from
June 25, 2024 09:28
da8dd60
to
489009a
Compare
abeddow91
approved these changes
Jun 25, 2024
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes the Opinion footer (straight lines) from Comment / Editorial / Letter cards.
Additionally simplifies some of the logic for card footer and when to render the footer in the different position for opinion cards
Why?
As part of the Fairground project team to simplify the front page UI.
Trello card
Screenshots