Track peer dependencies mismatches #6946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows tracking of current peer dependencies mismatches for all three workspaces in the following issue: #6945
sndrs
reviewed
Jan 12, 2023
| return new TextDecoder() | ||
| .decode(rawOutput) | ||
| .split('\n') | ||
| .filter((line) => line.includes('has incorrect peer dependency')) |
There was a problem hiding this comment.
this will break if yarn output changes (or this project gets a new package manager) – what about using something like https://www.npmjs.com/package/validate-peer-dependencies?
There was a problem hiding this comment.
Yes, that might be a good future improvement! I’m not massively interested in fixing straight away, as PNPM should make this unnecessary.
There was a problem hiding this comment.
I’ve actually tried this package, but could not get it to work at all!
|
this seems to be reporting AR has having no peerdep issues, but when i run |
|
Size Change: 0 B Total Size: 2.93 MB ℹ️ View Unchanged
|
Fixed in 0d08978 |
mxdvl
force-pushed
the
mxdvl/peer-dependencies
branch
from
81cdcda
to
0badf78
Compare
mxdvl
changed the title
OllysCoding
approved these changes
Jan 13, 2023
I don’t think it will because the “package” will not be identified. This can be improved upon, but a basic check seems better than nothing at all. |
This was referenced Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This allows tracking of current peer dependencies mismatches for all three workspaces in the following issue: #6945
Why?
A small step in gaining visibility over peer dependencies mistmaches.
Prompted by the recent bump to React 18 in #6787
Tested
I triggered a workflow which resulted in a successful run!