Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add europe and international in the high frequency paths #27171

Merged

Conversation

ioannakok
Copy link
Contributor

@ioannakok ioannakok commented May 22, 2024

Closes: guardian/dotcom-rendering#11311

What does this change?

Adds europe and international in the high frequency updated paths. They will be pressed every 2 minutes on CODE and every 1 minute in PROD.

Why?

These regular presses are triggered by a cron job running in the admin app and can have high, standard or low frequency. Editions and sports fronts have a high update frequency. In this PR I'm adding europe and international - they're missing possibly due to an oversight. This will allow the europe front to get the latest updates in the EU Election Tracker that will be launched this June. This content will be coming from CAPI and will change without any update from the Fronts tool.

See more about the fronts architecutre here: https://github.com/guardian/frontend/blob/main/docs/02-architecture/02-fronts-architecture.md

Screenshots

After deploying to CODE:

image

image

See also timestamps in the fronts bucket.

europe international
image image

Checklist

  • Tested locally, and on CODE if necessary

These fronts are pressed every 2 minutes in CODE and every 1 minute in PROD. These regular presses are triggered by a cron job running in the admin app and can have high, standard or low frequency. Editions and sports fronts have a high update frequency. The job is important because content for a front can be coming from CAPI and change without any update from the Fronts tool, e.g. a snap link. See more about the fronts architecutre here: https://github.com/guardian/frontend/blob/main/docs/02-architecture/02-fronts-architecture.md
@@ -10,7 +10,7 @@ import services.ConfigAgent

import scala.concurrent.{ExecutionContext, Future}

class FrontPressCron(liveFapiFrontPress: LiveFapiFrontPress, toolPressQueueWorker: ToolPressQueueWorker)(implicit
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing unused parameter

@ioannakok ioannakok marked this pull request as ready for review May 22, 2024 16:58
@ioannakok ioannakok requested a review from a team as a code owner May 22, 2024 16:58
@ioannakok ioannakok requested a review from JamieB-gu May 22, 2024 16:58
@ioannakok ioannakok merged commit 31dd5a9 into main May 31, 2024
3 checks passed
@ioannakok ioannakok deleted the add-europe-and-international-in-high-frequency-pressed-fronts branch May 31, 2024 09:43
@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD, ADMIN-PROD (merged by @ioannakok 14 minutes and 14 seconds ago)

@ioannakok
Copy link
Contributor Author

After merging this we can see both europe and international being pressed every 1 minute in PROD.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add /europe and /international (?) in the high frequency fronts refresh schedule
3 participants