Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Dependencies #994

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Upgrade Dependencies #994

merged 2 commits into from
Oct 11, 2021

Conversation

ob6160
Copy link
Contributor

@ob6160 ob6160 commented Oct 11, 2021 •
edited
Loading

What does this change?

Weekly upgrade to our dependencies. Skipping the major upgrade to eslint v8 because of some compatibility issues with typescript-eslint (tracked here: typescript-eslint/typescript-eslint#3738)

Also skips source kitchen upgrade due to some issues running the latest version that will be resolved in a separate PR

@ob6160 ob6160 requested a review from a team as a code owner October 11, 2021 12:23
coldlink
coldlink approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@coldlink coldlink left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrt the eslint changes, it also now requires a min version of node js, 14.18.

So we'd have to put in some effort also in updating the backend AMI image, as well as teamcity to use this.

@ob6160 ob6160 merged commit a800906 into main Oct 11, 2021
@ob6160 ob6160 deleted the ob/deps-upgrade branch October 11, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coldlink coldlink coldlink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ob6160 @coldlink