Refactor the metric classes #15
Conversation
daithiocrualaoich
commented
Aug 8, 2012
daithiocrualaoich
commented
- Genericize GaugeMetric
- Factor common implementation to AbstractMetric
- Add increment method to CountMetric
- Correct some sloppy attribute naming
- Add some tests
* Genericize GaugeMetric * Factor common implementation to AbstractMetric * Add increment method to CountMetric * Correct some sloppy attribute naming * Add some tests
|
@philwills Any chance you can once over this for me? |
|
|
||
| def count: Long = getCount() | ||
| def asJson: StatusMetric = StatusMetric(group, master map { _.definition }, name, `type`, title, description) |
There was a problem hiding this comment.
Don't we need the value in the JSON (I'm probably missing something here due to just looking at diffs)?
There was a problem hiding this comment.
Hard to see in the diff.
count was a convenience method only. The getCount came out in the JSON in the value attribute anyway. Count is also wrong language for a gauge. So it has all disappeared in favour of a getValue: () => T that gets passed into the constructor.
The sourcefile in full: https://github.com/guardian/guardian-management/blob/174f4332766cde372d361a80891ab7a359f86050/management/src/main/scala/com/gu/management/metrics.scala
The previous sourcefile: https://github.com/guardian/guardian-management/blob/0517d9bdf9b1799a0fb0dec370bc3eff6e7c8947/management/src/main/scala/com/gu/management/metrics.scala
|
👍 |
Refactor the metric classes
