This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Play 2.1 support (with Request metrics that work!) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note this does not actually pass tests, and no "org.mongodb" %% "casbah-core" % "2.5.0" yet - but it's coming: https://groups.google.com/d/topic/mongodb-casbah-users/Tiy9r2SMPcQ/discussion
http://teamcity.gudev.gnl:8111/viewLog.html?buildId=68043&buildTypeId=bt185&tab=buildLog [14:07:10][info] downloading http://repo1.maven.org/maven2/com/github/scala-incubator/io/scala-io-core_2.10/0.4.1/scala-io-core_2.10-0.4.1.jar ... [14:07:24][info] [SUCCESSFUL ] com.github.scala-incubator.io#scala-io-core_2.10;0.4.1!scala-io-core_2.10.jar (14096ms) [14:07:24][info] downloading http://repo1.maven.org/maven2/com/jsuereth/scala-arm_2.10/1.2/scala-arm_2.10-1.2.jar ... [14:07:26][info] [SUCCESSFUL ] com.jsuereth#scala-arm_2.10;1.2!scala-arm_2.10.jar (1480ms) [14:07:26][warn] [NOT FOUND ] javax.transaction#jta;1.0.1B!jta.jar (0ms) [14:07:26][warn] ==== public: tried [14:07:26][warn] http://repo1.maven.org/maven2/javax/transaction/jta/1.0.1B/jta-1.0.1B.jar [14:07:26][info] downloading http://repo1.maven.org/maven2/org/scalatest/scalatest_2.10/1.9.1/scalatest_2.10-1.9.1.jar ... [14:07:26][info] [SUCCESSFUL ] org.scalatest#scalatest_2.10;1.9.1!scalatest_2.10.jar (97ms) [14:07:26][info] downloading http://repo1.maven.org/maven2/org/mockito/mockito-core/1.9.5/mockito-core-1.9.5.jar ... [14:07:34][info] [SUCCESSFUL ] org.mockito#mockito-core;1.9.5!mockito-core.jar (8293ms) [14:07:34][warn] :::::::::::::::::::::::::::::::::::::::::::::: [14:07:34][warn] :: FAILED DOWNLOADS :: [14:07:34][warn] :: ^ see resolution messages for details ^ :: [14:07:34][warn] :::::::::::::::::::::::::::::::::::::::::::::: [14:07:34][warn] :: javax.transaction#jta;1.0.1B!jta.jar [14:07:34][warn] :::::::::::::::::::::::::::::::::::::::::::::: [14:07:34]sbt.ResolveException: download failed: javax.transaction#jta;1.0.1B!jta.jar jsuereth/scala-arm#21
Now using filters, and a bit more sane - the required configuration is much more concise. With a couple of tests too!
|
Fine with me. |
rtyley
added a commit
that referenced
this pull request
Jan 17, 2013
Play 2.1 support (with Request metrics that work!)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request metrics that count and time correctly for Async requests, and some actual tests for that too.
The first two commits are just upgrading all the dependencies - the third commit (217e60f) is probably the most interesting one.