This repository has been archived by the owner on Dec 6, 2022. It is now read-only.
Retain error/success border size and colour on :active state
#1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Select
ob6160
force-pushed
the
ob/error-success-active-state
branch
from
ee4845f
to
cd3cba8
Compare
ob6160
changed the title
ob6160
changed the title
:active state
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
We would like the border transition on
:activeto not happen when these components are in an error or success state.This gif demonstrates the current behaviour (clicking on the input to trigger
:active):What does this change?
This changes the behaviour so that when the select, text area and input
:activestate is activated and they are in error or success states the border remains the same.Accessibility
We had some discussions around the impact of this change upon accessibility. Namely, showing a flash of activation for keyboard/mouse users. The standard tab focus outer border will still work with this change. It would be interesting to hear peoples' opinion on this.
Perhaps, when the
:activestate is activated we could show a different shade of the error colour. Something like anerrorBorderActiveColour?