This repository has been archived by the owner on Dec 6, 2022. It is now read-only.
Don't use flexbox inside a fieldset #538
Merged
+31
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiAdcock
force-pushed
the
sa-horizontal-radio
branch
from
a371d65
to
47f29b0
Compare
SiAdcock
force-pushed
the
sa-horizontal-radio
branch
from
47f29b0
to
19687a1
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
There is a (recently fixed) bug in Chromium that prevents flexbox working correctly inside a fieldset. This manifests as an inability to switch the orientation of radio controls from vertical to horizontal using the
flex-directionproperty.Until this fix is rolled out and the next version of Chrome used more widely, we should find an alternative approach to layout within radio fieldsets.
What does this change?
display: blockandvertical-align: middleinstead of flex for layoutScreenshots
Before
After
Checklist
Accessibility
Cross browser and device testing