Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Play to 2.8.11, SBT to 1.5.7 #170

Merged
merged 13 commits into from
Dec 23, 2021
Merged

Bump Play to 2.8.11, SBT to 1.5.7 #170

merged 13 commits into from
Dec 23, 2021

Conversation

jonathonherbert
Copy link
Contributor

What does this change?

Bumps Play to 2.8.11, SBT to 1.5.7.

How to test

Run locally. (Do not deploy to CODE – it's waiting for #168!) The application should work as before.

@jonathonherbert jonathonherbert force-pushed the jsh/bump-play-and-sbt branch 2 times, most recently from bdcf16f to 49512f3 Compare December 17, 2021 16:33
@jonathonherbert jonathonherbert marked this pull request as ready for review December 17, 2021 17:07
SHession
SHession reviewed Dec 20, 2021
View reviewed changes
Copy link
Contributor

@SHession SHession left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and I've tested locally to see that it still works as expected. I'm seeing a few depreciation warnings when I compile which we may want to address. I have also left a couple of comments for your consideration.

script/set-node-version Show resolved Hide resolved
apps/checker/app/matchers/LanguageToolMatcher.scala Show resolved Hide resolved
@jonathonherbert
Copy link
Contributor Author

Thanks – hopefully addressed those comments.

SHession
SHession reviewed Dec 21, 2021
View reviewed changes
Copy link
Contributor

@SHession SHession left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a few compile issue locally and on TC by the looks of it. Might be off the back of my recommendations 😬

@jonathonherbert jonathonherbert mentioned this pull request Dec 21, 2021
Closed
@jonathonherbert
Copy link
Contributor Author

Just unearthed a fair few deprecation warnings via clean – working through them now.

tjsilver
tjsilver approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@tjsilver tjsilver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Composer with Typerighter running locally (changed config to point to .local) and all worked as expected. A few Scala 3 warnings when compiling but I guess these are for future-proofing as this project is using Scala 2.13..? Great work!
image

@tjsilver
Copy link
Contributor

Can confirm that the Scala 3 warnings are no longer since the last push.

@jonathonherbert jonathonherbert merged commit cc84994 into main Dec 23, 2021
@jonathonherbert jonathonherbert deleted the jsh/bump-play-and-sbt branch December 23, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SHession SHession SHession left review comments

@tjsilver tjsilver tjsilver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathonherbert @tjsilver @SHession