This repository has been archived by the owner on Sep 8, 2021. It is now read-only.
Add Design.Obituary
#151
Merged
Add Design.Obituary
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieB-gu
requested review from
gtrufitt,
oliverlloyd,
mohammad-haque,
buck06191,
abeddow91,
groakland and
joecowton1
oliverlloyd
approved these changes
Jun 23, 2021
joecowton1
approved these changes
Jun 23, 2021
abeddow91
approved these changes
Jun 23, 2021
|
This will need feeding up into the CAPI client as well at some point - whenever a type is added here it needs adding to the CAPI client and it's precedence needs determining as part of that e.g. guardian/content-api-scala-client#327 The earlier it sits in the predicates list, the higher its importance as compared to other categories. |
|
Relevant: guardian/content-api-scala-client#333 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
There's some unique styling for obituaries on Editions that we'd like to capture via
Design. It's possible we'll want unique styling on dotcom and apps too at some point.Changes
Design.Obituary