This repository has been archived by the owner on Sep 8, 2021. It is now read-only.
Added Letter To Design #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieB-gu
requested review from
gtrufitt,
sndrs,
oliverlloyd,
paperboyo,
frankie297,
abeddow91,
groakland and
joecowton1
oliverlloyd
approved these changes
Jan 27, 2021
+1 DesignTypes generally map from plural tone tag to singular designType https://github.com/guardian/content-api-scala-client/blob/63ca817bb8ad49eb8869603b74ec91247c0c6bfe/client/src/main/scala/com.gu.contentapi.client/utils/CapiModelEnrichment.scala#L19 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Although dotcom and apps give
LetterandCommentthe same design treatment, Editions has distinct designs for each. Therefore we need a way to differentiate between them in the model.Note:
LetterorLetters? The rest of theDesigntypes are all singular which is why I pickedLetterfor now.Changes
LettertoDesign