This repository has been archived by the owner on Sep 8, 2021. It is now read-only.
Added RETENTION_ENGAGEMENT_BANNER OphanComponentType #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This adds the
RETENTION_EPICtoOphanComponentType.A PR is currently underway to add that type to
Ophan.The Epic will only be available on DCR and not Frontend as most eligible articles are now rendered by DCR.
N.B
I managed to blunder into pushing straight to
mainwhile adding this change so it might be worth adding branch protection formainto the repo. That change is now reverted.