Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qualify generated reference to Predef.identity. fixes #211 #212

Merged
merged 3 commits into from
Mar 28, 2019

Conversation

dsilvasc
Copy link
Contributor

@dsilvasc dsilvasc commented Mar 27, 2019

The generated object Implicits contains this line:

implicit val showString = build[String](identity)

When the generated code lives in a package foo.bar.baz and another package foo.identity exists in the classpath, the generated code fails to compile with:

Implicits.scala:21: package identity is not a value
    implicit val showString = build[String](identity)

Changing identity to Predef.identity would avoid the issue.

I tried also _root_.Predef.identity but that fails to compile with object Predef is not a member of package <root>.

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowlege that all my contributions will be made under the project's license.

Copy link
Member

@blast-hardcheese blast-hardcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@blast-hardcheese blast-hardcheese merged commit 4822264 into guardrail-dev:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants