Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cats effect Async instead of Effect #224

Merged
merged 2 commits into from
Apr 3, 2019

Conversation

hanny24
Copy link
Contributor

@hanny24 hanny24 commented Apr 2, 2019

Both http4s generated server and client require implicit instance of Effect[F]. This seems as way too powerful constraint that limits certain use cases. One example would be type F[T] = ReaderT[IO, Context, T]. It does not have instance of Effect. If we were to change the requirement from Effect to Async, it would remove this limitation.

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@hanny24
Copy link
Contributor Author

hanny24 commented Apr 2, 2019

cc @tomasherman

Copy link
Member

@blast-hardcheese blast-hardcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my reading of cats' Effect, Sync, and Async, it seems as though this won't impact existing codebases, is that correct?

@hanny24
Copy link
Contributor Author

hanny24 commented Apr 3, 2019

Yes, existing codebases continue to work just fine as every Effect is also Async.

@blast-hardcheese
Copy link
Member

Very cool, thanks for the clarification.

@blast-hardcheese blast-hardcheese merged commit 4eb8ad6 into guardrail-dev:master Apr 3, 2019
@tomasherman tomasherman deleted the http4s-async branch October 22, 2019 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants