Added implicit show for Java URL type #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blast-hardcheese
requested changes
Jul 13, 2018
| @@ -5,6 +5,7 @@ import cats.syntax.either._ | |||
| import cats.~> | |||
| import com.twilio.guardrail.terms._ | |||
| import scala.meta._ | |||
| import java.net.URL | |||
There was a problem hiding this comment.
This import isn't necessary, for two reasons:
- you've specified the full type in
build[java.net.URL] - the line you've added below is inside
source""", which is a scala.meta string interpolator; we use the parsed structure that comes out of that string interpolator to write files that will then be compiled later (code generation, to be compiled by future invocations ofscalac)
There was a problem hiding this comment.
Gotcha. Thanks for the explanation.
blast-hardcheese
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This compiles, but I'm pretty unfamiliar with how Guardrail works, so I'm not sure if there are any other changes I need to make along with it. Just submitting this so we can iterate.