recorderOptions 'appendTo' option w/ constructor reformatting #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guest271314 -
I've been using you're npm package for a project and thought I'd help make some improvements.
I added a new option to the recorderOptions keyword argument. The user can specify a dom selector to which the audio node element will be appended. It defaults to body.
Also, I did a little bit of organizing in the constructor and moved certain code into three prototype methods:
This is simply to clean up the constructor a bit, as well as give the option in the future of cleanly allowing the user to specify options for the recorder or audio node and pass them as options.
best -
S