Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextView: Default background color has usability issues #1800

Closed
tig opened this issue Jun 13, 2022 · 3 comments · Fixed by #1971
Closed

TextView: Default background color has usability issues #1800

tig opened this issue Jun 13, 2022 · 3 comments · Fixed by #1971
Labels
bug

Comments

@tig
Copy link
Collaborator

tig commented Jun 13, 2022

In Wizards Scenario, I have what is essentially a modal dialog box with a TextView filling the client area:

image

Note how it's actually very hard to tell that this is a non-read-only/editible TextView.

I think TextView should use the same colors as TextField:

image
@tig tig added the bug label Jun 13, 2022
@BDisp
Copy link
Collaborator

BDisp commented Aug 2, 2022 •
edited
Loading

I think TextView should use the same colors as TextField:

I agree and I think the ColorScheme need to have two new Attribute for SelectedNormal and for for SelectedFocus which by default will be always the foreground and background colors inverted. Normally is used by the views the Focus color when the view is selected but this isn't enough for all views, like the TextView. What do you think?

@tig
Copy link
Collaborator Author

tig commented Aug 3, 2022

I think TextView should use the same colors as TextField:

I agree and I think the ColorScheme need to have two new Attribute for SelectedNormal and for for SelectedFocus which by default will be always the foreground and background colors inverted. Normally is used by the views the Focus color when the view is selected but this isn't enough for all views, like the TextView. What do you think?

I agree.

BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Aug 27, 2022
@BDisp
Fixes gui-cs#1800. TextView now uses the same colors as TextField.
1489cfd
@BDisp BDisp mentioned this issue Aug 27, 2022
Merged
8 tasks
@BDisp
Copy link
Collaborator

BDisp commented Aug 27, 2022

I thought better about it and decided not to create the new attributes just because of TextView and to avoid more complexity for ColorScheme.

@tig tig closed this as completed in #1971 Sep 15, 2022
tig added a commit that referenced this issue Sep 15, 2022
@BDisp @tig
Fixes #1800. TextView now uses the same colors as TextField. (#1971)
09f0054 
* Fixes #1800. TextView now uses the same colors as TextField.

* Replacing the textview to default in some scenarios.

* Removing TextView ColorScheme from the Wizard component.

* Changing someText color to be different from the help text color.

* Renamed some color methods as requested.

Co-authored-by: Tig Kindel <tig@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1800. TextView now uses the same colors as TextField. BDisp/Terminal.Gui
2 participants
@tig @BDisp