Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around VS2022 17.10.0 Preview 1.0 breaks collection expression for certain types #3293

Closed
tig opened this issue Mar 5, 2024 · 1 comment
Labels
bug build-and-deploy Issues regarding to building and deploying Terminal.Gui

Comments

@tig
Copy link
Collaborator

tig commented Mar 5, 2024

See https://developercommunity.visualstudio.com/t/VS2022-17100-Preview-10-breaks-collec/10596187

Until this is fixed, we should work around it by changing the collection intializer in

\UnitTests\Drawing\ColorTests.ParsingAndFormatting.cs:

https://github.com/gui-cs/Terminal.Gui/blob/eeced7e7727bae0e07db3dfd8938340cd10eadac/UnitTests/Drawing/ColorTests.ParsingAndFormatting.cs#L107C1-L115C14

@tig tig added bug build-and-deploy Issues regarding to building and deploying Terminal.Gui labels Mar 5, 2024
tig added a commit that referenced this issue Mar 5, 2024
Fixes #3293. Workaround VS2022 17.10.0 Preview 1.0 breaks collection expression fo…
@dodexahedron
Copy link
Collaborator

A thought, for cases that might come up where it's not a bug in VS.VNext (so not applicable to this one):

Do keep in mind that sometimes broken behavior in a pre-release VS version may be because of changes in .net 9, c# 13, or actual fixes to bad behavior in the current stable version.

Or, they may be buggy behavior in the new version.

So it's important to be sure the end result of a change for that is fully analyzed, so we don't accidentally make a change that has a subtly broken behavior or omission for the latest .net LTS release we support.

What is relevant to this one is that last part. That change isn't 1-to-1 with the previous code, because the collections aren't the same.

@tig tig closed this as completed Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug build-and-deploy Issues regarding to building and deploying Terminal.Gui
Projects
None yet
Development

No branches or pull requests

2 participants