Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3431. TextView and TextField are showing the cursor beyond their limits. #3432

Merged
merged 11 commits into from
Apr 30, 2024
Merged

Fixes #3431. TextView and TextField are showing the cursor beyond their limits. #3432

merged 11 commits into from
Apr 30, 2024

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Apr 24, 2024

Fixes

Proposed Changes/Todos

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner April 24, 2024 18:56
tig
tig requested changes Apr 25, 2024
View reviewed changes
Terminal.Gui/Views/TextField.cs Outdated Show resolved Hide resolved
BDisp and others added 7 commits April 25, 2024 23:30
@BDisp
Create IsViewLocationVisibleInViewport method.
46fcb58
@BDisp
Applying dispose.
986c681
@tig
Fixed Charmap focus bug
eecb7dc
@tig
Prototype/WIP for revamping how cursor handling works.
e6da3db 
Views should not have to do complex cursor logic just to position / show a cursor.
Application should take care of more of the heavy liftig.
Advanced cursor handling should be possible.
ProcessCursor is poorly designed and fragile.
@BDisp
Merge pull request #176 from tig/BDisp-v2_textview-textfield-cursor-f…
960215f 
…ix_3431

Prototype/WIP for revamping how cursor handling works
@BDisp
Improves @tig prototype.
d074ff0
@tig
Merge branch 'v2_develop' into v2_textview-textfield-cursor-fix_3431
f55d7e6
tig
tig approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are failing.

Other than whatever that is, I think this is worth merging even though we'll eventually refactor Cursor susport per cursor.md.

@BDisp do you agree?

@BDisp
Copy link
Collaborator Author

BDisp commented Apr 30, 2024

Unit tests are failing.

It's not failing here.

Other than whatever that is, I think this is worth merging even though we'll eventually refactor Cursor susport per cursor.md.

@BDisp do you agree?

Yes I agree.

@tig
Copy link
Collaborator

tig commented Apr 30, 2024

Unit tests are failing.

It's not failing here.

Other than whatever that is, I think this is worth merging even though we'll eventually refactor Cursor susport per cursor.md.
@BDisp do you agree?

Yes I agree.

Can you please merge in the cursor.md PR?

@tig tig mentioned this pull request Apr 30, 2024
Open
@BDisp
Copy link
Collaborator Author

BDisp commented Apr 30, 2024

Can you please merge in the cursor.md PR?

Done.

@tig tig merged commit 02e08fe into gui-cs:v2_develop Apr 30, 2024
1 check passed
@BDisp BDisp deleted the v2_textview-textfield-cursor-fix_3431 branch April 30, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tig tig tig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BDisp @tig