Convert unit tests to NUnit 4.0 #259
Conversation
Takes care of the CodeQL warnings from #15
Takes care of 2 inspections VS was throwing
Replaces GetArray Using framework naming convention for methods that return boolean status and have out parameters that are non-null on success There's another use of the old method, but I have to stare at it a bit more to see what it's really doing. Might need to discuss that one when we chat.
…o convert-tests-to-constraint-model Interim merge for #15 There's more to be done, but I'm going to get back to test conversion for a bit, now that several of the loudest issues are addressed
|
Hey sorry for this, looks like it closed when I merged Can you please re-open and target |
|
No problem. Will do when I next touch it, probably later today. Since I'll be rebasing, I'll probably squash a few commits, in the process. Just FYI in case you happen to have checked any of it out, since there will be force pushes. |
|
Cool, let me know when it is ready <3 |
|
Opening up a new one, shortly. This one includes some commits under the src folder, mostly for formalizing a couple of things and also for adding new stuff, as part of a gradual process to eliminate some reflection, where possible. A lot of tests have been unrolled into unique cases, and some tests are much more thorough, now (especially in the CodeDomArgsTests class). All tests pass, and the tested cases are a superset of cases that were previously tested. I would suggest not merging, yet, as I have some incomplete in-progress modifications happening to the github workflows to make them leaner and give us better control over them. We should probably chat about that stuff at some point, too, to be sure the final behavior is as desired. |
|
Here ya go Opened #260 |
Opening this PR now, to provide easy tracking of work done on this back at the master repo.
This is not ready for merge at this time, though you are certainly free to merge whenever and as often as you like. I'll change this from draft status when the work is done.