Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GUIDv4.php #124

Merged
merged 3 commits into from
Apr 21, 2024
Merged

Update GUIDv4.php #124

merged 3 commits into from
Apr 21, 2024

Conversation

guibranco
Copy link
Owner

No description provided.

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 21, 2024
Copy link

deepsource-io bot commented Apr 21, 2024

Here's the code health analysis summary for commits 5914de2..c630e0b. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource SQL LogoSQL✅ SuccessView Check ↗
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource PHP LogoPHP✅ SuccessView Check ↗
DeepSource Docker LogoDocker✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePhp
Branch Coverage100%100%
Composite Coverage98.8%98.8%
Line Coverage98.8%98.8%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@guibranco guibranco enabled auto-merge (squash) April 21, 2024 23:33
Copy link

codacy-production bot commented Apr 21, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5914de2) 164 162 98.78%
Head commit (c630e0b) 164 (+0) 162 (+0) 98.78% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#124) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (5914de2) to head (c630e0b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files           6        6           
  Lines         160      160           
=======================================
  Hits          158      158           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@guibranco guibranco merged commit 6121ac6 into main Apr 21, 2024
28 checks passed
@guibranco guibranco deleted the guibranco-patch-2 branch April 21, 2024 23:34
@@ -11,7 +11,7 @@
{
public function testCanBeEmptyGUID(): void
{
$this->assertSame('00000000-0000-0000-8000-000000000000', GUIDv4::empty());
$this->assertSame('00000000-0000-0000-0000-000000000000', GUIDv4::empty());

Check warning

Code scanning / Phpmd (reported by Codacy)

Static access leads to hard to test code Warning test

Avoid using static access to class '\GuiBranco\Pancake\GUIDv4' in method 'testCanBeEmptyGUID'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant