Fixed duplicate shape ID in for-loop issue (#296) #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuchiraD
force-pushed
the
shapes-in-loops-fix
branch
from
c9ed045
to
0043743
Compare
|
Thanks a lot for the effort! Good idea to re-use the image id counter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change repetitive IDs inside mc:AlternateContent.
Issue
When there are shapes inside a for-loop command, the shapes will be generated with same id in wp:docPr and <v:shape>. This will show a
corrupted filemessage when opening the docx file in MS-WordFix
Change the IDs of wp:docPr and <v:shape> before adding them to the final xml structure