chore: use reverse dependency tree in oao publish #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeroenptrs
changed the title
guigrpa
requested changes
Jul 18, 2020
src/__tests__/publish.test.js
Outdated
Comment on lines
57
to
61
| try { | ||
| await publish(merge(NOMINAL_OPTIONS)); | ||
| } catch (err) { | ||
| throw new Error('SHOULD_NOT_HAVE_THROWN'); | ||
| } |
There was a problem hiding this comment.
What's the purpose of this try-catch block? If the publish() fails, the test will already fail…
There was a problem hiding this comment.
Ok I'll remove it
|
@guigrpa pls re-review. Since we're doing |
|
Hmmm, what would be the added value of the "alphabetical" publishing? If it's not evident, I would remove the flag entirely. |
|
@guigrpa updated PR, please review :) |
guigrpa
approved these changes
Jul 20, 2020
|
Good to go, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #101
This would allow users to run
oao publish --treeso the leaves of a dependency tree get published first