Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mergeDeep function #14

Merged
merged 1 commit into from
Oct 25, 2017
Merged

Add mergeDeep function #14

merged 1 commit into from
Oct 25, 2017

Conversation

dentrado
Copy link
Contributor

This PR adds a mergeDeep function to timm.

I recently replaced seamless-immutable with timm in a project, which gave a nice perfomance boost :) The only thing missing when making the transition was a way to merge deeply (I used Lodash's merge({}, obj1, obj2) as a temporary solution, but that obviously isn't ideal since it always creates a new object).

From what I can tell when running the benchmarks on this branch vs master, adding this had no measurable impact on performance for the regular merge.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 70c59c6 on dentrado:deep-merge into fe040c5 on guigrpa:master.

@guigrpa
Copy link
Owner

guigrpa commented Oct 25, 2017

This is a useful addition to the library, thanks!

@guigrpa guigrpa merged commit 2d7ae1d into guigrpa:master Oct 25, 2017
@guigrpa
Copy link
Owner

guigrpa commented Oct 25, 2017

Shipped in v1.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants