Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript definition #23

Merged
merged 2 commits into from Jul 23, 2018
Merged

Typescript definition #23

merged 2 commits into from Jul 23, 2018

Conversation

grrowl
Copy link
Contributor

@grrowl grrowl commented Jul 20, 2018

Added a typescript definition for timm's public interface, ported from the .flow definition. Copies the .d.ts into lib on build (like the flow one), and adds "types" to package.json as per the TypeScript documentation

I haven't tested pulling this down into our project yet (via build + npm link) but can confirm the types work as intended.

@coveralls
Copy link

coveralls commented Jul 20, 2018

Coverage Status

Coverage remained the same at 99.281% when pulling 4c3b407 on ActivePipe:typescript-definition into 78141d9 on guigrpa:master.

@guigrpa
Copy link
Owner

guigrpa commented Jul 23, 2018

Thanks, that's a really great addition to the library!

@guigrpa guigrpa merged commit 60c407c into guigrpa:master Jul 23, 2018
@guigrpa
Copy link
Owner

guigrpa commented Jul 23, 2018

Shipped in v1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants