Handle negative and decimal paths for setIn.
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now all numeric values will create an array if needed. Keys that are not positive integers are added as properties to that array.
guigrpa
reviewed
Dec 8, 2016
| // ... unknown paths create intermediate keys: | ||
| setIn({ a: 3 }, ['unknown', 'path'], 4) | ||
| // { a: 3, unknown: { path: 4 } } | ||
| // ... unknown paths create intermediate keys. Numeric segments are treated as array indices: |
There was a problem hiding this comment.
The README is generated automatically based on comments with // -- in src/timm.js. Please update those as well
|
LGTM, except for the docs. I'll do that myself, don't worry. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All numeric values will create an array if needed. Keys that are not positive integers are added as properties to that array. Some related discussion in #3.