Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding scrape duration and status. #9

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Adding scrape duration and status. #9

merged 2 commits into from
Mar 16, 2021

Conversation

guilbaults
Copy link
Owner

New gauges added to store the scrape duration and scrape_ok

# HELP infiniband_ibqueryerrors_duration_seconds Number of seconds taken to run ibqueryerrors
# TYPE infiniband_ibqueryerrors_duration_seconds gauge
infiniband_ibqueryerrors_duration_seconds 2.2388930320739746
# HELP infiniband_scrape_duration_seconds Number of seconds taken to collect and parse the stats
# TYPE infiniband_scrape_duration_seconds gauge
infiniband_scrape_duration_seconds 3.6977221965789795
# HELP infiniband_scrape_ok Indicate with a 1 if the scrape is valid
# TYPE infiniband_scrape_ok gauge
infiniband_scrape_ok 1.0

Also improving the internal web server, this remove the sleep(1)

@gabrieleiannetti
Copy link
Contributor

Hi,

this is great. Just for the completeness, I would write as HELP text for infiniband_scrape_ok:
Indicate with a 1 if the scrape is valid, otherwise 0

Thank you.

I will try the next exporter version soon... Then we will see how long the ibqueryerrors command will take 👍 .

We are currently facing times about ~38 seconds...

Best
Gabriele

@guilbaults guilbaults merged commit c6eef51 into master Mar 16, 2021
@guilbaults guilbaults deleted the scrape_info branch March 16, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants