Pathfinding #1 #10
Merged
Pathfinding #1 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature/add-pathfinding
guilhermelhr
requested changes
Nov 28, 2020
Merged
guilhermelhr
requested changes
Nov 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small step towards our goal however the Pathfinding is fully functional (with still some hiccups to figure out and to change Lists do Sets to reduce complexity).
Also the height reading from binary had some problems which was causing every Cell to have its height set to 0 🤷♂️
I think the ideal solution would be to translate roBrowser/rAthena pathfinding. This algorithm has the neighbour code from rAthena however I think we could get it to behave exactly like rAthena