Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: resetting zoom should set the zoom level to the saved zoom level instead of 100% #108

Closed
sudomain opened this issue Dec 12, 2022 · 3 comments

Comments

@sudomain
Copy link

Thank for the improvements to the app, particularly raw encoding and saved zoom levels for portrait/landscape. Currently the reset zoom button will set the zoom to 100%, even if the saved zoom level(s) are a different value. I think it should probably reset to the saved value instead, please.

Thanks again for your work.

@gujjwal00
Copy link
Owner

Well, I wanted to make sure that user was able to 'clear' default zoom by going back to 100%. There were couple more alternatives I thought about:

  1. On tap reset to default zoom, on long-press reset to 100%
  2. Use two buttons, one for default, and one for 100%

I am personally in favor of no. 1, but I was worried about discoverability.

@sudomain
Copy link
Author

Makes sense. If I may I'd also like to suggest:

  1. Tapping a zoom button would create horizontal menu that would very much similar in style to the virtual keys, but instead of keys there could be buttons to save the current zoom to the default, and set the current zoom to various presets including 100% (maybe 10%, 25%, 50%, 100%, and a number input?)
  2. The zoom setting seems to be saved per host, based on what I could tell from some tests. Maybe there could be a slider and reset button in edit server settings? Perhaps this could be in addition to option you ultimately choose?

Just an idea I had. Once again, thank you for the great app

gujjwal00 added a commit that referenced this issue Mar 26, 2023
@gujjwal00
Copy link
Owner

For now, I have implemented option 1 (v2.2.1 is now available). If it doesn't work well, I will implement option 2 or 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants