Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support less v4 #313

Merged
merged 1 commit into from
Jun 16, 2021
Merged

feat: support less v4 #313

merged 1 commit into from
Jun 16, 2021

Conversation

Helium-Z
Copy link

Hi Chris, I have removed the dependence on accord as your suggestion. And the new logic is totally extracted from the accord.
Please review the code and release a new version of this plugin

@Helium-Z Helium-Z mentioned this pull request May 23, 2021
@yocontra
Copy link
Member

Thanks @MisterLuffy - have you tested that this works across multiple less versions? I'm not sure what accord was doing to support all 3 versions, or if it was really this simple.

@Helium-Z
Copy link
Author

Helium-Z commented May 25, 2021

Thanks @MisterLuffy - have you tested that this works across multiple less versions? I'm not sure what accord was doing to support all 3 versions, or if it was really this simple.

I have tested less v3 and v4, and the logic of extracting from accord is exactly same as before.
In fact, let accord support Less v4 is very simple, just need to change the name of this file to [2.x - 4.x.coffee]. Because accord only unifies the API parameters, and the render API between Less v3 and v4 has not changed.

@stamminator
Copy link
Contributor

This PR resolves the failing Travis CI build case

@yocontra
Copy link
Member

yocontra commented May 27, 2021

@MisterLuffy If you haven't tested it on the 2.x stuff it might be best to just drop support for that at this point - the next release (with these changes) is going to be a major bump anyways. 2.x is ~5yrs old and based on the npm stats not in wide enough usage to justify keeping support for it, most people are using 3.x and 4.x.

@Helium-Z
Copy link
Author

@contra Agree with you. I have modified package.json and README, tested less v3/v4 and everything is fine

@ayyash
Copy link

ayyash commented Jun 8, 2021

Any updates to this, I can't wait :)

@yocontra yocontra merged commit ea13d8a into gulp-community:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants