feat: handle extglobs (parentheses) containing separators

gulpjs · Jan 27, 2021 · 7db1bdb · 7db1bdb
1 parent 8269bd8
commit 7db1bdb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -13,7 +13,7 @@ module.exports = function globParent(str) {
 
 	// remove path parts that are globby
 	do {str = pathDirname.posix(str)}
-	while (isglob(str) || /(^|[^\\])[\{\[]/.test(str));
+	while (isglob(str) || /(^|[^\\])([\{\[]|\([^\)]+$)/.test(str));
 
 	// remove escape chars and return result
 	return str.replace(/\\([\*\?\|\[\]\(\)\{\}])/g, '$1');

diff --git a/test.js b/test.js
@@ -94,6 +94,9 @@ describe('glob-parent', function() {
     assert.equal(gp('path/foo\\[a\\\/]/'), 'path/foo[a\\\/]');
     assert.equal(gp('foo[a\\\/]'), '.');
     assert.equal(gp('foo\\[a\\\/]'), 'foo[a\\\/]');
+    assert.equal(gp('path/(foo/bar|baz)'), 'path');
+    assert.equal(gp('path/(foo/bar|baz)/'), 'path');
+    assert.equal(gp('path/\\(foo/bar|baz)/'), 'path/(foo/bar|baz)');
   });
 
   it('should handle nested braces', function() {