Skip to content

Commit 312e1db

Browse files
committed
Update: Handle unsupported versions better
1 parent dfc5713 commit 312e1db

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

index.js

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ var path = require('path');
66
var gutil = require('gulp-util');
77
var chalk = require('chalk');
88
var nomnom = require('nomnom');
9-
var semver = require('semver');
109
var Liftoff = require('liftoff');
1110
var tildify = require('tildify');
1211
var interpret = require('interpret');
@@ -117,14 +116,6 @@ function handleArguments(env) {
117116
exit(1);
118117
}
119118

120-
// Check for semver difference between cli and local installation
121-
// TODO: remove when we support all
122-
if (semver.gt(cliVersion, env.modulePackage.version)) {
123-
gutil.log(chalk.red('Warning: gulp version mismatch:'));
124-
gutil.log(chalk.red('Global gulp is', cliVersion));
125-
gutil.log(chalk.red('Local gulp is', env.modulePackage.version));
126-
}
127-
128119
// Chdir before requiring gulpfile to make sure
129120
// we let them chdir as needed
130121
if (process.cwd() !== env.cwd) {
@@ -138,6 +129,12 @@ function handleArguments(env) {
138129
// Find the correct CLI version to run
139130
var range = findRange(env.modulePackage.version, ranges);
140131

132+
if (!range) {
133+
return gutil.log(
134+
chalk.red('Unsupported gulp version', env.modulePackage.version)
135+
);
136+
}
137+
141138
// Load and execute the CLI version
142139
require(path.join(__dirname, '/lib/versioned/', range, '/'))(opts, env);
143140
}

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
"matchdep": "^0.3.0",
1616
"nomnom": "^1.8.0",
1717
"pretty-hrtime": "^1.0.0",
18-
"semver": "^5.0.0",
1918
"semver-greatest-satisfied-range": "^1.0.0",
2019
"tildify": "^1.0.0",
2120
"v8flags": "^2.0.9",

0 commit comments

Comments
 (0)