Skip to content

Commit 672b8a8

Browse files
committed
Fix: Revert displayName change from #53 & add regression test
1 parent 61e4054 commit 672b8a8

File tree

8 files changed

+51
-2
lines changed

8 files changed

+51
-2
lines changed

.eslintignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
**/*.babel.js

.jscsrc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
{
2-
"preset": "gulp"
2+
"preset": "gulp",
3+
"excludeFiles": ["**/*.babel.js"]
34
}

lib/shared/registerExports.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ function registerExports(gulpInst, tasks) {
1414
return;
1515
}
1616

17-
gulpInst.task(task.displayName || taskName, task);
17+
gulpInst.task(taskName, task);
1818
}
1919
}
2020

package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@
4747
"yargs": "^3.28.0"
4848
},
4949
"devDependencies": {
50+
"babel-preset-es2015": "^6.5.0",
51+
"babel-register": "^6.5.1",
5052
"code": "^1.2.1",
5153
"coveralls": "^2.7.0",
5254
"eslint": "^1.7.3",

test/expected/tasks-as-exports.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
gulp-cli/test
2+
├── build
3+
├── clean
4+
└─┬ dist
5+
└─┬ <series>
6+
├── clean
7+
└── build

test/exports-as-tasks.js

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
'use strict';
2+
3+
var lab = exports.lab = require('lab').script();
4+
var code = require('code');
5+
var fs = require('fs');
6+
var child = require('child_process');
7+
8+
var output = fs.readFileSync(__dirname + '/expected/tasks-as-exports.txt', 'utf8').replace(/(\r\n|\n|\r)/gm,'\n');
9+
10+
// Long timeout is required because parse time is slow
11+
lab.experiment('exports as tasks', { timeout: 0 }, function() {
12+
13+
lab.test('prints the task list', function(done) {
14+
15+
child.exec('node ' + __dirname + '/../bin/gulp.js --tasks --gulpfile "./test/fixtures/gulpfile-exports.babel.js"', function(err, stdout) {
16+
code.expect(stdout).to.contain('Tasks for');
17+
stdout = stdout.replace(/\\/g, '/').split('Tasks for')[1].split('\n');
18+
var outputArray = output.split('\n');
19+
for (var i = 0; i < stdout.length; i++) {
20+
code.expect(stdout[i]).to.contain(outputArray[i]);
21+
}
22+
done(err);
23+
});
24+
});
25+
26+
});

test/fixtures/.babelrc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"presets": ["es2015"]
3+
}
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
// jscs:disable
2+
3+
'use strict';
4+
5+
import gulp from 'gulp';
6+
7+
export function clean(){};
8+
export function build(){};
9+
export const dist = gulp.series(clean, build);

0 commit comments

Comments
 (0)