Code refactoring for gutil.PluginError #75
Conversation
|
Just to let you know, this module will be deprecated when gulp 4 comes out. We will instead encourage people to use small modules, for example gutil.PluginError is being replaced by a module called BetterError. Most of gulp-util is just pointers to other modules at this point, once everything is done being broken out the README will instead point to these other modules and recommend that people don't use gulp-util. Making a kitchen sink module was a really bad idea. That being said, thanks for the PR it still fixes a lot of problems. 🍻 |
| var self = this; | ||
|
|
||
| properties = properties | ||
| .map(function(prop) { return '\n ' + prop + ': ' + self[prop]; }) |
There was a problem hiding this comment.
can you space this out to multiple lines and name the anonymous functions (for clarity)? Not a fan of one liner functions anymore
* add .jshintrc * quicken CI build (ref: http://goo.gl/m6glri) * remove .npmignore
Probably it fixes this issue: #69
* introduce shinnn/istanbul-coveralls * let JSHint work correctly * remove mocha’s —reporter option * Mocha uses spec reporter by default.
* remove unused variables * use .containEql method instead of .indexOf * remove unnecessary trailing slashes
* _.filter -> array-differ * _.uniq -> array-uniq * _.defaults -> object-assign
Code refactoring for gutil.PluginError
I really agree with you. I'm looking forward to gulp 4 :) |
|
@contra Could you release a new patch-updated version? Although this module will be depreceted, it's worth doing that for the present. |
|
@shinnn 3.0.2 |
|
@contra Thanks! |
sudo: falseto .travis.yml for faster CI build..jshintrc..npmignoreand addedfilesfield to package.json instead.coverallsscript.testscript to let JSHint work correctly..should.not.equal(-1)with.containEql.