add support for arbitrary node-flags #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
failed the linter btw |
|
fixed. |
| cli.on('respawn', function (flags, child) { | ||
| var nodeFlags = chalk.magenta(flags.join(', ')); | ||
| var pid = chalk.magenta(child.pid); | ||
| gutil.log('Node flags detected:', nodeFlags); |
There was a problem hiding this comment.
is this logging really needed? can't it be totally transparent?
There was a problem hiding this comment.
Hmm. I suppose it isn't strictly needed. Perhaps it could be behind a verbosity flag? You do similar (arguably unnecessary) logging now, like informing the user when an external module is required, or that the cwd is changing. I'm not deeply invested either way.
There was a problem hiding this comment.
I think we should have it, what is the harm in being a little verbose when we already are really verbose? It gets hidden by the --silent flag already.
yocontra
pushed a commit
that referenced
this pull request
Sep 13, 2014
add support for arbitrary node-flags
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can test this by running node 0.11 and using
--harmonyto run a gulpfile that uses generators.