fix!: Ensure project works with different streams #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that I didn't combine things like |
|
I've workshopped this a ton with @mafintosh so I'm going to go ahead and merge it. I'm also going to merge it as a breaking change to v3 because the implementation is drastically different. |
phated
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once I finish getting all these tests to pass, this closes #5 - as I believe it was trying to determine if various types of streams would work with this project. @coreyfarrell can correct me if I am wrong.
I found that streamx streams actually can't be used with
leadand I am trying to account for the differences. This will rely on mafintosh/streamx#11 and probably anisFlowingfunction as mentioned in mafintosh/streamx#16It also seems that the node core streams have broken one of the test and I want to see which version broke that.
I've also updated the example in the readme so this closes #7 when it lands.