feat(clone): option to not clone buffer, support custom properties #15
Conversation
option `{ contents: false }` causes the clone to reference-copy buffer contents.
Custom properties that exist in the original file are reference-copied.
Add documentation for the new `contents: false` option on the `clone` function.
| var clonedStat = this.stat ? cloneStats(this.stat) : null; | ||
|
|
||
| return new File({ | ||
| var newFile = new File({ | ||
| cwd: this.cwd, |
There was a problem hiding this comment.
Do we still need to specify these since we are cloning all properties anyways?
There was a problem hiding this comment.
I worked around the inbuilt properties in my loop so as to use the constructor where I could, just in case the constructor ends up doing something more interesting in the future. Subject to your other comment, I guess that all properties could be deep cloned, and then I can test whether or not to call cloneBuffer afterward based on the flag. On the deep cloning, do you have a favorite method? How about https://github.com/pvorb/node-clone?
There was a problem hiding this comment.
@stu-salsbury Not sure which is more performant, but I'm sure lodash has a pretty good deep clone
There was a problem hiding this comment.
Lodash it is. My preference anyway. I was looking for something small and targeted, but it's not like this is running in a browser, thankfully.
There was a problem hiding this comment.
@stu-salsbury You can install only certain pieces of lodash (like http://npmjs.org/lodash.clone)
All properties of the original file are deep-cloned into the new file, with the exception of contents and stat, which both require special handling.
|
I had to keep the manual cloning of stat, since it's not a POJSO. |
|
If you want me to squash the commits and do a new PR once this is all settled, I'm cool with that. |
Remove full lodash dependency. Depend only on lodash.cloneDeep.
|
Closing in favor of #16. |
option
{ contents: false }causes the clone to reference-copy buffer contents.Custom properties that exist in the original file are reference-copied.