Ending streams properly and using the node common pipe behavior #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests and the functionality look fine but it doesn't adhere to the code style of the repo. I'll merge it and make the changes for style since they aren't documented |
|
Can you add documentation for the added functionality before I merge? |
|
I documented the new behavior in the readme. Just for my information, what's coding style you use ? |
phated
pushed a commit
that referenced
this pull request
Sep 27, 2016
phated
pushed a commit
that referenced
this pull request
Sep 27, 2016
phated
pushed a commit
that referenced
this pull request
Sep 27, 2016
phated
pushed a commit
that referenced
this pull request
Sep 27, 2016
phated
pushed a commit
that referenced
this pull request
Sep 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some issue on switching from streams to buffers since piping the buffer didn't end the stream when piping a stream did. This could break some code but that code would break also when switching from buffer to streams anyway.
Here is my proposal to make it a bit more consistent by using the current NodeJS pipe method signature. Hope you'll find it usefull.