-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Add isSymbolic method and symlink property (closes #79) #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if this is done but #101 needs some of the logic. I can tweak this later before the major bump if necessary. |
phated
added a commit
that referenced
this pull request
Sep 27, 2016
phated
added a commit
that referenced
this pull request
Sep 27, 2016
phated
added a commit
that referenced
this pull request
Sep 27, 2016
phated
added a commit
that referenced
this pull request
Sep 27, 2016
phated
added a commit
that referenced
this pull request
Sep 27, 2016
phated
added a commit
that referenced
this pull request
Sep 27, 2016
phated
added a commit
that referenced
this pull request
Sep 27, 2016
phated
added a commit
that referenced
this pull request
Sep 27, 2016
phated
added a commit
that referenced
this pull request
Sep 27, 2016
phated
added a commit
that referenced
this pull request
Sep 27, 2016
phated
added a commit
that referenced
this pull request
Sep 27, 2016
phated
added a commit
that referenced
this pull request
Sep 27, 2016
phated
added a commit
that referenced
this pull request
Sep 27, 2016
phated
added a commit
that referenced
this pull request
Sep 27, 2016
phated
added a commit
that referenced
this pull request
Sep 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@contra please review. I am linking these changes into my local vinyl-fs to utilize the changes and things seem to be working. I avoided a bunch of throws to allow for this to be released as a minor (I think it should be fine as that).