Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some VPAID won't emit the 'AdRemainingTimeChange' event #82

Closed
edrpls opened this issue Jan 28, 2020 · 0 comments
Closed

Some VPAID won't emit the 'AdRemainingTimeChange' event #82

edrpls opened this issue Jan 28, 2020 · 0 comments

Comments

@edrpls
Copy link

edrpls commented Jan 28, 2020

Describe the bug
Some VPAID sources won't emit the AdRemainingTimeChange event. The current code depends entirely on this event to emit the playback-progress event. We could either add a fallback when the event is not emitted by the time onAdVideoFirstQuartile runs or just emit the playback-progress event at 25%, 50%, 75% and 100% since at least on of these listeners is always implemented.

Smartphone :

  • Device: iPhones, Android
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edrpls