Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for inline VAST XML #99

Closed
torbenbrodt opened this issue Jul 16, 2021 · 2 comments
Closed

Add support for inline VAST XML #99

torbenbrodt opened this issue Jul 16, 2021 · 2 comments

Comments

@torbenbrodt
Copy link
Contributor

torbenbrodt commented Jul 16, 2021

Is your feature request related to a problem? Please describe.
Many SSPs like Xandr/AppNexus return the VAST XML as string in the bidresponse.
I want to use this video player to play such videos.
Unfortunately this video player only supports URLs, via the config.src attribute.

Describe the solution you'd like
The library can handle VAST XML as string when using URL Blobs.
If we add an example more people will know about it.

Describe alternatives you've considered
As an alternative we can provide a custom options.urlhandler which does not require XHR and parses the string directly.

Additional context
Bidresponse of Xandr
image

Example for Inline VAST

<?xml version="1.0" encoding="UTF-8"?>
<VAST xmlns:xsi="https://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="vast.xsd" version="3.0">
    <Ad>
        <InLine>
            <Creatives>
                <Creative sequence="1">
                    <Linear>
                        <Duration>00:01:00</Duration>
                        <VideoClicks>
                            <ClickThrough id="GDFP"><![CDATA[https://iabtechlab.com]]></ClickThrough>
                        </VideoClicks>
                        <MediaFiles>
                            <MediaFile id="GDFP" delivery="progressive" type="video/mp4"><![CDATA[https://aba.gumgum.com/13861/8/big_buck_bunny_640x360.mp4]]></MediaFile>
                        </MediaFiles>
                    </Linear>
                </Creative>
            </Creatives>
        </InLine>
    </Ad>
</VAST>
torbenbrodt added a commit to opinary/gg-ez-vp that referenced this issue Jul 16, 2021
torbenbrodt added a commit to opinary/gg-ez-vp that referenced this issue Jul 16, 2021
edrpls pushed a commit that referenced this issue Jul 22, 2021
@edrpls
Copy link

edrpls commented Jul 22, 2021

@torbenbrodt Just wanted to confirm that #100 fixes this issue before closing it.

@edrpls edrpls closed this as completed Aug 2, 2021
@edrpls
Copy link

edrpls commented Aug 2, 2021

Closing because of #100. This might get first-class support in the future.

Thanks, @torbenbrodt, for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants